SpellCritDamageBonusOrderTest.cpp File Reference

#include "Util.h"
#include "gtest/gtest.h"

Go to the source code of this file.

Classes
class	SpellCritDamageBonusOrderTest

Functions
	TEST_F (SpellCritDamageBonusOrderTest, NoModifiers)
	TEST_F (SpellCritDamageBonusOrderTest, OnlyAuraMod)
	TEST_F (SpellCritDamageBonusOrderTest, OnlyTalentMod)
	TEST_F (SpellCritDamageBonusOrderTest, Issue24976_HunterSteadyShot)
	TEST_F (SpellCritDamageBonusOrderTest, BothMods_LargerValues)

Function Documentation

TEST_F() [1/5]

TEST_F	(	SpellCritDamageBonusOrderTest	,
		BothMods_LargerValues
	)

{
    int32 damage = 1000;
    float auraMod = 3.0f;
    float talentMod = 40.0f;
 
    // Correct: 2000*1.03=2060, bonus=1060, *1.40=1484, +1000=2484
    EXPECT_EQ(CorrectCritOrder(damage, auraMod, talentMod), 2484);
 
    // Wrong: 1000*1.40=1400, total=2400, *1.03=2472
    EXPECT_EQ(OldWrongCritOrder(damage, auraMod, talentMod), 2472);
 
    EXPECT_GT(CorrectCritOrder(damage, auraMod, talentMod),
              OldWrongCritOrder(damage, auraMod, talentMod));
}

TEST_F() [2/5]

TEST_F	(	SpellCritDamageBonusOrderTest	,
		Issue24976_HunterSteadyShot
	)

{
    int32 damage = 320;
    float auraMod = 3.0f;    // meta gem: +3% crit damage
    float talentMod = 40.0f; // Mortal Shots etc: +40% SPELLMOD_CRIT_DAMAGE_BONUS
 
    EXPECT_EQ(OldWrongCritOrder(damage, auraMod, talentMod), 791);
    EXPECT_EQ(CorrectCritOrder(damage, auraMod, talentMod), 794);
    EXPECT_GT(CorrectCritOrder(damage, auraMod, talentMod),
              OldWrongCritOrder(damage, auraMod, talentMod));
}

TEST_F() [3/5]

TEST_F	(	SpellCritDamageBonusOrderTest	,
		NoModifiers
	)

{
    EXPECT_EQ(CorrectCritOrder(1000, 0.0f, 0.0f), 2000);
    EXPECT_EQ(OldWrongCritOrder(1000, 0.0f, 0.0f), 2000);
}

TEST_F() [4/5]

TEST_F	(	SpellCritDamageBonusOrderTest	,
		OnlyAuraMod
	)

{
    EXPECT_EQ(CorrectCritOrder(1000, 30.0f, 0.0f), 2600);
    EXPECT_EQ(OldWrongCritOrder(1000, 30.0f, 0.0f), 2600);
}

TEST_F() [5/5]

TEST_F	(	SpellCritDamageBonusOrderTest	,
		OnlyTalentMod
	)

{
    // Correct: bonus = 2000-1000 = 1000, *1.03 = 1030, +1000 = 2030
    // Old: crit_bonus = 1000*1.03 = 1030, total = 2030
    EXPECT_EQ(CorrectCritOrder(1000, 0.0f, 3.0f), 2030);
    EXPECT_EQ(OldWrongCritOrder(1000, 0.0f, 3.0f), 2030);
}